Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click on tab -> open in finder on Mac has unclear functionality and can break the instance #576

Closed
kasplat opened this issue Apr 23, 2019 · 0 comments · Fixed by #586
Labels
bug Something isn't working

Comments

@kasplat
Copy link

kasplat commented Apr 23, 2019

  • code-server version: v1.696-vsc1.33.0
  • OS Version: Mac Mojave locally on latest version of chrome, Ubuntu 18.04 remotely

Description

When you right click on a tab, "Reveal in Finder" appears. I've clicked on it in a previous version of code server and it opened the file in its own folder without allowing me to get out of the folder. I just tested it, and it appears to just refresh the window and do nothing else. This isn't super crucial, but it doesn't seem like it should exist on a remote browser since finder should not be able to open the file at all.

I personally think that option should just be removed since it is possible for users to accidentally click it, and it is confusing.

Steps to Reproduce

  1. Open any file in Code Server
  2. Right click the tab and click on the "Open in finder" dialog
@kasplat kasplat added the bug Something isn't working label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant