Colors do not match up with VSCode

[Octelly]

• code-server version: unsure, downloaded from the Docker repository today (15th May 2019 around 18:00)
• OS Version: Docker host (host OS is Ubuntu Server 18.04.2 LTS)

Description

Color themes do not match up with VSCode

Monokai (default theme) in Coder

Monokai (default theme) in VSCode + Bracket Colorizer 2 (color of the brackets is besides the point)

Steps to Reproduce

1. Open Coder and Visual Studio Code
2. Select the same color theme in both (ctrl+shit+p > Prefferences: Color Theme)
3. Compare

[sr229]

@johnystar this is a UA-specific bug, remember that despite they use the same renderers, Electron has more modifications and is a bit behind in the Chromium version than your browsers.

[sr229]

@johnystar does this still persist? if not I can ping a maintainer to close this.

[Octelly]

@sr229 Yes, it does. (I created a new Coder Docker container to check)

[deansheather]

I don't see a difference in the colors besides the brackets. Likely just a difference in rendering in your browser vs. VS Code/Electron as sr229 said.

[Octelly]

@deansheather It's a shame really because I'm using a completely unmodified version of Google Chrome.

[sr229]

@johnystar Electron renders differently compared to Chrome/Chromium despite using the same base.

CC @deansheather for closure. UA-specific issue, not fixable within the codebase.

[sr229]

I'll go ahead close this for now since the deviation is not affecting UX significantly.