Skip to content

Reflect new location of vscodeVersion #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Reflect new location of vscodeVersion #1327

merged 1 commit into from
Feb 4, 2020

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Feb 2, 2020

The build instructions on README.md referred to the wrong place to find the VS Code Version.

sr229
sr229 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though keeping up with our Git Logs will tell which current upstream we use will suffice.

@code-asher code-asher merged commit 50234e5 into coder:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

+1 more reviewer

@sr229 sr229 sr229 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpmct @sr229 @code-asher