Skip to content

Symlink node_modules.asar to node_modules in lib/vscode #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2020
Merged

Symlink node_modules.asar to node_modules in lib/vscode #2482

merged 3 commits into from
Dec 18, 2020

Conversation

code-asher
Copy link
Member

Closes #2197.

Base automatically changed from issue-1587-submodule-to-subtree to master December 17, 2020 22:29
@code-asher code-asher requested a review from nhooyr December 17, 2020 22:40
nhooyr
nhooyr reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

nhooyr
nhooyr approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@code-asher code-asher merged commit c7baf5d into master Dec 18, 2020
@code-asher code-asher deleted the asar branch December 18, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nhooyr nhooyr nhooyr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @nhooyr