feat(testing): add unit tests for constants #2701
Conversation
| "wtfnode": "^0.8.4", | ||
| "typescript": "^4.1.3" | ||
| "typescript": "^4.1.3", | ||
| "wtfnode": "^0.8.4" |
There was a problem hiding this comment.
I wonder if this was a manual change or something done automatically? Not particularly an issue, just curious 👀
There was a problem hiding this comment.
I think that happens when you add a new dependency to the top? Not sure, I did see it in one of Asher's PRs
There was a problem hiding this comment.
Yeah yarn resorts the dependencies. 😄
There was a problem hiding this comment.
The real question is how it got out of order in the first place lol
There was a problem hiding this comment.
LOL I have no idea - could have been me 😂
There was a problem hiding this comment.
Haha idk I say we just blame yarn.
| // Things to mock | ||
| // logger | ||
| // location | ||
| // document |
There was a problem hiding this comment.
Comment disappeared! no other changes in this file; curious about the change
There was a problem hiding this comment.
That was intentional! See commit: 164d11e
feat(testing): add unit tests for src/common/http
This PR refactors a few lines of code in
src/node/constants.tsand adds a few unit tests to bring code coverage for the file to 100%.Changes
constantsand addgetPackageJsonfunction to make it easier to test@schemastore/packageto devDeps to get PackageJson typeScreenshot
It increases our code coverage (Lines) from 49.53% to 50.09% (↑ 0.56%).
🟩 100% Line coverage (last 100) for
src/node/constants.tsTODOS