Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct command to Open Folder on Welcome page #3437

Merged
merged 2 commits into from
May 21, 2021
Merged

fix: use correct command to Open Folder on Welcome page #3437

merged 2 commits into from
May 21, 2021

Commits on May 21, 2021

  1. chore: update CHANGELOG

    @jsjoeio
    jsjoeio committed May 21, 2021
    Configuration menu
    Copy the full SHA
    a46030d View commit details
    Browse the repository at this point in the history

  2. fix: use openFolder in welcomePage 

    In 1.56.2, they modified the WelcomePage use of OpenFileFolder in
src/vs/workbench/contrib/debug/browser/welcomeView.ts to only use on macOS +
Desktop (i.e. not Web). This caused the "Open Folder" to not work on macOS +
macOS-like environments.

Instead, we use OpenFolder which is a registered command and works as expected.
    @jsjoeio
    jsjoeio committed May 21, 2021
    Configuration menu
    Copy the full SHA
    3a426e4 View commit details
    Browse the repository at this point in the history