Check version #362
Closed
Check version #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Docker version we compile doesn't get a version number. Might be a different issue, but it'd be nice to get version checking in there too :) |
The docker image eventually inherits the source code from the binary so as soon as the CI catches up (if and when) this is merged it should work for the docker image as well. |
lsmoura
suggested changes
Mar 28, 2019
kylecarbs
requested changes
Mar 28, 2019
lsmoura
reviewed
Mar 29, 2019
lsmoura
reviewed
Mar 29, 2019
added 15 commits
April 17, 2019 17:49
Co-Authored-By: nol166 <jmccamb@gmail.com>
Co-Authored-By: nol166 <jmccamb@gmail.com>
|
resolved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Checks to see if there is a newer release available when running the CLI
Is there an open issue you can link to?
Fixes #213.