Fix: use pipe to spawn http server process to enable logs pipe to files #4293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we use `inherit` in stdio param to spawn the http server process(or the child process), which will swallow the logs in child process and not be written to the `code-server-stdout.log`. Using `pipe` will fix this problem.
|
@code-asher do you mind reviewing this? I think last time we changed this code, it was when we found that bug thanks to the help from the |
code-asher
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we use
inheritin stdio param to spawn the http server process(or the child process), which will swallow the logs in child process and not be written to thecode-server-stdout.log. Usingpipewill fix this problem.Fixes #