Skip to content

Conversation

tobycm
Copy link
Contributor

@tobycm tobycm commented Dec 24, 2022

Fixes #5922

@tobycm tobycm requested a review from a team as a code owner December 24, 2022 22:49
@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 3, 2023

Thank you for doing this! Since we don't have e2e tests for this patch, what is your proposed testing plan?

cc @code-asher - mind helping review?

@code-asher
Copy link
Member

code-asher commented Jan 3, 2023

I might be missing something. This seems to do the opposite of the PR title?

Before changeset: domain.tld/a/b/c/code/ would register at ./ which is domain.tld/a/b/c/code/ (register on subpath root)
After changeset: domain.tld/a/b/c/code would register at / which is domain.tld (register on domain root)

@tobycm tobycm changed the title change scope to subpath root instead of domain root so service worker will work on subpath change scope to subpath root instead of domain root so PWA will be installable on subpath Jan 3, 2023
@tobycm
Copy link
Contributor Author

tobycm commented Jan 3, 2023

My bad guys. The service worker works, just the PWA is not installable.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 3, 2023

My bad guys. The service worker works, just the PWA is not installable.

Ah got it. And does this fix that? I posted in the original issue that it works as expected on Coder so I think first we'd need steps to reproduce.

@tobycm
Copy link
Contributor Author

tobycm commented Jan 4, 2023

I will reproduce this again when I got my Ubuntu Server up and running.

(don't know why it's failing installing GRUB 5 times in a row 😭 )

@code-asher code-asher added the waiting-for-info Waiting for more information from submitter label Feb 13, 2023
ghost

This comment was marked as spam.

@code-asher
Copy link
Member

@tobycm I am going to close the PR for inactivity but if you start working on it again we can re-open.

@code-asher code-asher closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info Waiting for more information from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PWA is not installable when code-server is on subpath
4 participants