Update Code to 1.84.2 #6524
Update Code to 1.84.2 #6524
Conversation
|
Hmmm... 1.84.1 and 1.84.2 are from the same commit. So this pull request is identical to #6519 and @code-asher Should this be released, please mention |
|
Found and updated the commit for Code 1.84.2. |
|
Hi! Can merge soon? Thanks! |
|
@code-asher It would be great to have a release by the end of this week. Thank you. |
|
Should be able to, I will be back tomorrow. |
code-asher
force-pushed
the
code-1.84.2
branch
from
1fa88e7
to
7bf09b3
Compare
code-asher
force-pushed
the
code-1.84.2
branch
from
7bf09b3
to
862e7f0
Compare
|
@code-asher can we have a release please? 🙏 |
|
@code-asher Regarding https://github.com/coder/code-server/actions/runs/6884702807/job/18727700812#step:7:22: Python v3.12.0 is problematic. Use an older macOS image that still provides Python v3.11. |
|
Ahh thanks! I will look into downgrading. |
|
Weird, supposedly it is using macOS 12.6.9 but the last run that succeeded was actually a version higher, 12.7. The run before that (also successful) used 12.6.9. Maybe I can downgrade just Python. |
The last successful run used https://github.com/actions/runner-images/blob/macOS-12/20230921.4/images/macos/macos-12-Readme.md: Python3 3.11.5 https://github.com/coder/code-server/actions/runs/6884702807/job/18727700812#step:7:22 used https://github.com/actions/runner-images/blob/macOS-12/20231029.1/images/macos/macos-12-Readme.md: Python3 3.12.0 |
|
All right, I put out an RC, will promote it tomorrow if no one reports anything amiss. |
|
I tested again with the release candidate. As far as code-server is concerned, everything seems to be fine. I ran into randy3k/radian#446, but that has nothing to do with this project. |
|
Awesome, thank you! I did some testing as well and it looks good. I will put out a full release today. |
@microsoft also updated the commit for Code 1.84.2: https://github.com/microsoft/vscode/releases/tag/1.84.2 |
Fixes #6516