Skip to content

Conversation

8sd
Copy link
Contributor

@8sd 8sd commented May 20, 2019

Describe in detail the problem you had and how this PR fixes it

Is there an open issue you can link to?

@8sd 8sd requested review from code-asher and kylecarbs as code owners May 20, 2019 08:29
@code-asher
Copy link
Member

Funnily enough, the doc is actually correct as it currently stands. We
need to add the comma here as well: https://github.com/cdr/code-server/blob/db39eacfa1fa15b3f4aaa44e6469f71d58b4d07b/packages/server/src/cli.ts#L31

Co-Authored-By: Sergio Moura <sergio@moura.ca>
@8sd
Copy link
Contributor Author

8sd commented May 28, 2019

@lsmoura thanks for the hint :)
@code-asher Ithanks, I didn't know there was this second help

@code-asher
Copy link
Member

code-asher commented Jun 5, 2019

@8sd our final check requires the commits to be signed; once that's done we'll merge this in! 🎉

@8sd
Copy link
Contributor Author

8sd commented Jul 8, 2019

The commits are now verified

@deansheather deansheather merged commit 5e8c3f8 into coder:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants