Dockerfile: cleanup and add en_US.UTF-8 locale #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 7, 2019
|
CI failures are related to rate limits so merging this anyway. @kylecarbs is this a known issue? |
|
Yup its known. I've attempted to find a good solution. Might need to jank within the CI. |
|
@kylecarbs Unrelated to this issue, but I didn't see another one referencing that problem: Have you tried using travis-ci's caching mechanism? It'd reduce the number of calls your throwing to NPM I believe. https://docs.travis-ci.com/user/caching/ is the full documentation. It is generally as simple as adding this to your ci file: |
|
Hmm. Will add this. Thanks @Omeryl ! |
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
Dockerfile: cleanup and add en_US.UTF-8 locale
1 task
jsjoeio
pushed a commit
that referenced
this pull request
Jun 1, 2021
Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
jsjoeio
pushed a commit
that referenced
this pull request
Jun 1, 2021
Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
jsjoeio
pushed a commit
that referenced
this pull request
Jun 1, 2021
Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
Closes #83
Thanks @xMrWhite, @frol and @sr229.