Skip to content

Conversation

ibetitsmike
Copy link
Contributor

No description provided.

@ibetitsmike ibetitsmike requested a review from deansheather July 21, 2025 08:31
@deansheather deansheather marked this pull request as ready for review July 28, 2025 04:14
using (await _opLock.LockAsync(ct))
// Grab the lock again so we can update the state. Don't use the CT
// here as it may have already been canceled.
using (await _opLock.LockAsync(TimeSpan.FromSeconds(5), CancellationToken.None))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug I noticed on startup when the server was unreachable, it would timeout the CT and then never set the status to "invalid" so the tray window would always be stuck in the loading state

@ibetitsmike ibetitsmike merged commit 814b412 into main Jul 28, 2025
3 checks passed
@ibetitsmike ibetitsmike deleted the fix/enable-opt-in-tailscale-loop-prevention branch July 28, 2025 16:37
deansheather added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants