Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: passthrough subsystem env vars #51

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: passthrough subsystem env vars #51

merged 1 commit into from
Aug 8, 2023

Conversation

deansheather
Copy link
Member

Currently the CODER_AGENT_SUBSYSTEM env var passed to the inner container is always set to envbox regardless of the parent value. This will pass the parent value if it's set and append envbox to it, ensuring that envbox isn't already there.

@deansheather deansheather requested a review from sreya August 7, 2023 07:08
@sreya sreya merged commit 16470c2 into main Aug 8, 2023
9 checks passed
@sreya sreya deleted the dean/passthrough-subsystems branch August 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreya sreya sreya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @sreya