chore: add Makefile and local registry cache #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Apr 24, 2024
| ./scripts/develop.sh | ||
|
|
||
| build: scripts/envbuilder-$(GOARCH) | ||
| ./scripts/build.sh |
There was a problem hiding this comment.
These seem like they should be phony atm?
|
|
||
| .PHONY: test | ||
| test: test-registry test-images | ||
| go test -count=1 ./... |
There was a problem hiding this comment.
Count will disable go caching, let's remove it as I imagine anyone developing the project would prefer caching on?
| .registry-cache: | ||
| mkdir -p .registry-cache && chmod -R ag+w .registry-cache | ||
|
|
||
| .registry-cache/docker/registry/v2/repositories/envbuilder-test-alpine: |
There was a problem hiding this comment.
These should perhaps depend on the test-registry?
| @@ -605,7 +609,7 @@ func TestPrivateRegistry(t *testing.T) { | |||
| }) | |||
| t.Run("Auth", func(t *testing.T) { | |||
| t.Parallel() | |||
| image := setupPassthroughRegistry(t, "library/alpine", ®istryAuth{ | |||
| image := setupPassthroughRegistry(t, "envbuilder-test-alpine:latest", ®istryAuth{ | |||
There was a problem hiding this comment.
Is it intentional to use hard-coded name here, compared to e.g. testImageAlpine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakefileNote: there is an existing in-memory registry implementation that I looked into using instead, but this was cheaper to implement.