Skip to content

Conversation

BrunoQuaresma
Copy link
Contributor

Close #175

@BrunoQuaresma BrunoQuaresma requested review from johnstcn and mtojek May 14, 2024 12:58
@BrunoQuaresma BrunoQuaresma self-assigned this May 14, 2024
@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 14, 2024 13:57
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me once we have a couple more test cases for invalid git URLs. I don't think I need to review again.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 14, 2024 16:24
@BrunoQuaresma BrunoQuaresma disabled auto-merge May 14, 2024 16:26
@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 14, 2024 16:51
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 14, 2024 17:44
@BrunoQuaresma BrunoQuaresma merged commit ca425f7 into main May 14, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-git-url-parse branch May 14, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: handle git URLs that are not valid URLs
2 participants