Fix FeatureContexts keys #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be updated to correspond to the changes in coder#205.
aaronlehmann
force-pushed
the
fix-feature-contexts
branch
from
b037c01
to
c6d64e7
Compare
johnstcn
approved these changes
Jun 19, 2024
devcontainer/devcontainer_test.go
Outdated
| }) | ||
|
|
||
| t.Run("WithBuildContexts", func(t *testing.T) { | ||
| params, err := dc.Compile(fs, "", magicDir, "", "", true, os.LookupEnv) |
There was a problem hiding this comment.
nit, non-blocking: I know this is a pre-existing convention, but using os.LookupEnv here has potential to introduce test flakes. What would you think about swapping it out with a simple stub func() instead?
There was a problem hiding this comment.
Good idea - done.
johnstcn
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be updated to correspond to the changes in #205.