feat: avoid generating repeated type constraints #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Jul 29, 2025
Comment on lines
8
to
10
| type Repeated[T string | string | int64 | uint64] struct { | ||
| Value T | ||
| } |
There was a problem hiding this comment.
Let's add a non-literal type as well, as the simplify change only dedupes literals. An eventual change might be to dedupe these as well 🤷
Suggested change
| type Repeated[T string | string | int64 | uint64] struct { | |
| Value T | |
| } | |
| type Foo struct{} | |
| type Repeated[T string | string | int64 | uint64 | Foo | Foo] struct { | |
| Value T | |
| } |
There was a problem hiding this comment.
I tried that but Go failed to type-check because it's invalid code. Can't define the same type twice as generic constraint
bindings/declarations.go
Outdated
|
|
||
| func simplifyUnion(union *UnionType) *UnionType { | ||
| types := []ExpressionType{} | ||
| set := map[string]bool{} |
There was a problem hiding this comment.
Since the set is only tracking literals, can we rename this? If we eventually add deduping more complex types, I think we will need to come up with some other compare mechanism
Suggested change
| set := map[string]bool{} | |
| literalsSet := map[string]bool{} |
Emyrk
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for a solution for #40 (now implemented/merged in #41) I stumbled upon the simplify function and I found it weird that it tracked multiple times the same types.
Types are unique so it now only tracks each time once.
There was already a test for this so I've only updated it.