build: use static glibc linking for Linux releases #76
+136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches Linux releases from musl to static glibc (gnu) targets with crt-static. This change is necessary because V8 doesn't provide prebuilt musl binaries and building V8 from source for musl fails with 404 errors on dependency downloads. Changes: - Update build.rs to configure static-libgcc for Linux gnu targets - Add scripts/build-static.sh for building with RUSTFLAGS crt-static - Update release workflow to use x86_64/aarch64-unknown-linux-gnu targets - Remove musl build script and ARM64 cross-compilation setup Benefits: - Fully statically linked binaries (static-pie) for excellent portability - Tested working on Ubuntu 18.04 (glibc 2.27) and CentOS 7 (glibc 2.17) - Binary size: 52M unstripped / 39M stripped (comparable to dynamic builds) - Fast builds using V8 prebuilt binaries (no 20-30min source compilation) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ammario
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
The build script determined target solely from uname -m, causing ARM64 builds on x86_64 runners to produce wrong architecture binaries. Changes: - Update build-static.sh to accept target as argument - Pass matrix.target from workflow to build script - Re-add ARM64 cross-compilation tools setup - Improve output messages to distinguish auto-detected vs specified targets Fixes the P0 issue where aarch64-unknown-linux-gnu builds failed because the script built x86_64 binaries while tarball step expected aarch64. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements static linking for Linux releases to improve portability across different Linux distributions.
Problem
Current Linux releases use dynamic linking, which means:
Solution
Use static glibc linking with the gnu target and
crt-staticflag:static-pieChanges
build.rsto configure-static-libgccfor Linux gnu targetsscripts/build-static.shfor building withRUSTFLAGS="-C target-feature=+crt-static"Testing
Verified on ci-1 (Debian 12, glibc 2.36):
static-pie)$ file httpjail httpjail: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), static-pie linked, for GNU/Linux 3.2.0, not stripped $ ldd httpjail statically linkedBenefits
Note on musl
We use gnu (glibc) instead of musl because V8 doesn't provide prebuilt musl binaries and building V8 from source for musl is not currently feasible.
🤖 Generated with Claude Code