Replace godirwalk with fs.WalkDir #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Aug 20, 2024
| return filepath.SkipDir | ||
| } | ||
| return nil | ||
| filesystem.WalkDir(dir, func(path string, ent fs.DirEntry, err error) error { |
There was a problem hiding this comment.
Review: I didn't add err handling here, surprised at how much err handling is missing but didn't feel like this PR is the right place to add it.
johnstcn
approved these changes
Aug 20, 2024
mafredri
force-pushed
the
mafredri/remove-godirwalk-dep
branch
from
2655b9d to
49af11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #22 and replaces one lib requiring
osfile operations.I measured the performance of
godirwalkandfs.WalkDiron the Linux kernel source and there were no major performance differences.See also: https://engineering.kablamo.com.au/posts/2021/quick-comparison-between-go-file-walk-implementations/