This repository was archived by the owner on May 15, 2025. It is now read-only.
Add new nodejs module
#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Mar 1, 2024
matifali
reviewed
Mar 1, 2024
|
Thanks for the review! I think fixed all issue but one (see comment) |
matifali
suggested changes
Mar 1, 2024
|
Hmm very strange, I pushed changes to my branch and even rebased onto the latest @mafredri Any idea why this could be? |
@TheZoker We'll have to wait, sit tight 😄 https://www.githubstatus.com/incidents/wcl1sw4mzg60 |
|
@mafredri Alright, seems like the Github sync job has caught up. Can you check if the script is ok now? Thanks! |
mafredri
reviewed
Mar 1, 2024
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
matifali
approved these changes
Mar 1, 2024
|
@mafredri Since we set |
|
Thanks for the reviews and the merge 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a node installer module. It is powered by NVM. By default it installs the latest version of node and makes that the default. But the user can also provide a list of node versions, they like to install and also a custom default node version as well.
I'm not 100% sure about the naming. Other possible names for the module:
nvmnodenodejsWhat you you prefer?
Note:
nodeinstalls the latest version of node.