This repository was archived by the owner on May 15, 2025. It is now read-only.
fix: fix misc. issues #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
changed the title
name field to coder_parameter
matifali
changed the title
name field to coder_parameter
|
@bpmct can you approve this one? |
bpmct
approved these changes
Sep 26, 2023
.images/kasmvnc.png
Outdated
There was a problem hiding this comment.
this is novnc. can you remove this for now?
.sample/run.sh
Outdated
| echo "Instalalting ${MODULE_NAME}..." | ||
| echo "Instalalting MODULE_NAME..." |
Comment on lines
-23
to
+24
| icon = "https://raw.githubusercontent.com/jglovier/dotfiles-logo/main/dotfiles-logo-icon.svg" | ||
| icon = "/icon/dotfiles.svg" |
kasmvnc/README.md
Outdated
| @@ -29,11 +31,24 @@ Automatically install [KasmVNC](https://kasmweb.com/kasmvnc) in a workspace, and | |||
| module "kasmvnc" { | |||
| source = "https://registry.coder.com/modules/kasmvnc" | |||
| agent_id = coder_agent.example.id | |||
| version = "1.0.0" | |||
| custom_version = "1.0.0" | |||
There was a problem hiding this comment.
just curious: why are you calling it custom_version?
There was a problem hiding this comment.
version is a reserved keyword and is not allowed in terraform.
kasmvnc/README.md
Outdated
| ``` | ||
|
|
||
| ![Screenshot of KasmVNC]() //TODO | ||
| > **Note:** It is recommended to pre-install a desktop environment in your Dockerfile/VM image to speed up the startup time of your workspace. |
There was a problem hiding this comment.
🙌🏼
I know you are removing this for now, but this module will be top-tier once we get it working
There was a problem hiding this comment.
I am sad as I have spent 10+ hours on trying to make it universal :/
Comment on lines
+15
to
+20
|
|
||
| ```hcl | ||
| module "vscode" { | ||
| source = "https://registry.coder.com/modules/vscode-desktop" | ||
| agent_id = coder_agent.example.id | ||
| } |
There was a problem hiding this comment.
I hope we can get coder/coder#9604 (comment) in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namefield tocoder_parameter