Skip to content

fix: use a more generic powershell error fragment for Windows probing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix: use a more generic powershell error fragment for Windows probing #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/process/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ const (
// windowsPowershellCommandNotFoundFragment is a fragment of the error output
// returned on Windows systems running Powershell when a command cannot be
// found.
windowsPowershellCommandNotFoundFragment = "is not recognized as the name of a cmdlet, function, script file, or operable program."
// Different Windows versions use slightly error messages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Different Windows versions use slightly error messages.
// Different Windows versions use slightly different error messages.

// i.e. "is not recognized as the name of a cmdlet, function, script file, or operable program."
// "is not recognized as a name of a cmdlet, function, script file, or executable program."
windowsPowershellCommandNotFoundFragment = "cmdlet, function, script file, or"
)

// OutputIsPOSIXCommandNotFound returns whether or not a process' error output
Expand Down
Loading