-
Notifications
You must be signed in to change notification settings - Fork 56
feat: add configurable Devolutions Gateway version for windows-rdp module #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dule - Add devolutions_gateway_version variable with default to latest version (2025.2.1) - Update PowerShell script to use configurable version instead of hardcoded 2024.1.5 - Add comprehensive documentation for all variables in README - Include example usage with custom version Resolves #145 Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
## Variables | ||
|
||
| Name | Description | Type | Default | Required | | ||
| ----------------------------- | ---------------------------------------------- | -------- | ----------------- | -------- | | ||
| `agent_id` | The ID of a Coder agent | `string` | n/a | yes | | ||
| `resource_id` | The ID of the primary Coder resource (e.g. VM) | `string` | n/a | yes | | ||
| `admin_username` | Administrator username for RDP access | `string` | `"Administrator"` | no | | ||
| `admin_password` | Administrator password for RDP access | `string` | `"coderRDP!"` | no | | ||
| `devolutions_gateway_version` | Version of Devolutions Gateway to install | `string` | `"2025.2.1"` | no | | ||
| `share` | Sharing level for the RDP app | `string` | `"owner"` | no | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Variables | |
| Name | Description | Type | Default | Required | | |
| ----------------------------- | ---------------------------------------------- | -------- | ----------------- | -------- | | |
| `agent_id` | The ID of a Coder agent | `string` | n/a | yes | | |
| `resource_id` | The ID of the primary Coder resource (e.g. VM) | `string` | n/a | yes | | |
| `admin_username` | Administrator username for RDP access | `string` | `"Administrator"` | no | | |
| `admin_password` | Administrator password for RDP access | `string` | `"coderRDP!"` | no | | |
| `devolutions_gateway_version` | Version of Devolutions Gateway to install | `string` | `"2025.2.1"` | no | | |
| `share` | Sharing level for the RDP app | `string` | `"owner"` | no | |
Delete this section as we parse all variables in the registry frontend, so no need to add it in README.md
The registry frontend automatically parses variables, so manual documentation is not needed. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Thanks for the review feedback @matifali! I've removed the Variables section from the README as requested since the registry frontend automatically parses variables. The PR now focuses on the core functionality while keeping the example that demonstrates how to use the new Changes made:
|
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
I'll address the version bump requirement. Based on the CI feedback, the module version needs to be updated from |
I'm experiencing workspace connectivity issues that prevent me from pushing the version bump changes directly. The version references that need to be updated in the README are:
This is a minor version bump since we're adding a new feature ( @matifali Could you help with the version bump, or would you prefer me to retry once the workspace connectivity is restored? |
This PR addresses issue #145 by adding the ability to specify the Devolutions Gateway version in the windows-rdp module.
Changes Made
devolutions_gateway_version
variable with default set to the latest version (2025.2.1
)2024.1.5
Benefits
Testing
Resolves #145