Skip to content

feat: support codex cli #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Aug 19, 2025
Merged

feat: support codex cli #281

merged 53 commits into from
Aug 19, 2025

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Aug 1, 2025

Closes #236
/claim #236

Description

https://www.loom.com/share/4a39d1c2e2324cb2b6f90c1ad6893602?sid=d5211d2c-a2cd-41ae-8580-15ac686756f2

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/[namespace]/modules/[module-name]
New version: v1.0.0
Breaking change: [ ] Yes [ ] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@algora-pbc algora-pbc bot mentioned this pull request Aug 1, 2025
6 tasks
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 1, 2025

@matifali PR ready for review

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 1, 2025

coder/coder#19118

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 4, 2025

@hugodutka @DevelopmentCats, please review and let me know if this needs any changes :)

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 5, 2025

@hugodutka thanks for the review, committed the suggested changes.

@35C4n0r 35C4n0r requested a review from hugodutka August 5, 2025 17:10
Copy link
Contributor

@hugodutka hugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just some nits. I expect we'll merge after the next review.

35C4n0r and others added 4 commits August 7, 2025 22:07
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 14, 2025

@hugodutka done !

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 15, 2025

It looks like everything was merged for agent api. I will pull and test this module today, and then we should be able to get this merged @35C4n0r

@DevelopmentCats please let me know if this needs any changes.

@DevelopmentCats
Copy link
Contributor

Sorry my server that I host was having some problems over the weekend. I will make sure that I pull this and test it today so we can get it merged :)

matifali
matifali previously approved these changes Aug 18, 2025
… to Codex module

- Introduced new variables for sandbox configuration: sandbox_mode, approval_policy, and network_access.
- Updated README to reflect the new variables and their usage.
- Modified install and start scripts to utilize the new variables for better configuration management.
@DevelopmentCats DevelopmentCats self-requested a review August 19, 2025 03:46
bpmct
bpmct previously approved these changes Aug 19, 2025
@35C4n0r 35C4n0r dismissed stale reviews from bpmct and DevelopmentCats via 28edf08 August 19, 2025 04:21
@35C4n0r 35C4n0r requested a review from matifali August 19, 2025 05:23
@matifali matifali merged commit 0e1dcd3 into coder:main Aug 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codex Module
5 participants