Skip to content

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Apr 3, 2025

This PR closes #364

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely worth an integration test :-)

Base automatically changed from jjs/363 to main April 7, 2025 06:20
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR is ready for review yet, is it?

@SasSwart SasSwart marked this pull request as draft April 10, 2025 10:09
// and after the workspace was claimed by a user.
//
// agentID is unused for now, but will be used as soon as we support multiple agents.
func RunningAgentTokenEnvironmentVariable(agentID string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will the ID be injected? How will we maintain a persistent identity across terraform apply runs?

@dannykopping dannykopping self-requested a review April 17, 2025 11:34
@SasSwart SasSwart marked this pull request as ready for review April 23, 2025 12:06
@SasSwart SasSwart merged commit 5648efb into main May 2, 2025
6 checks passed
@SasSwart SasSwart deleted the jjs/364 branch May 2, 2025 06:57
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the workspace agent can reuse its existing token when required
4 participants