Skip to content

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 30, 2025

Some of these cases you would expect it to be an error, but the validation passes

Some of these cases you would expect it to be an error, but the
validation passes
@@ -18,6 +20,8 @@
| NumDefOpts | number | | 5 | 1,3,5,7 | 2-6 | | 5 | true | |
| NumDefNotOpts | number | | 5 | 1,3,7,9 | 2-6 | | | | valid option |
| NumDefInvOpt | number | | 5 | 1,3,5,7 | 6-10 | | | | 6 < 5 < 10 |
| NumDefNotNum | number | | a | | | | | | a number |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can pass in "a" for a "number" param... interesting.

You can see it for yourself:

data "coder_parameter" "region" {
  name        = "region"
  type        = "number"
  order       = 1
}
$ CODER_PARAMETER_c697d2981bf416569a16cfbcdec1542b5398f3cc77d2b905819aa99c46ecf6f6=nan terraform apply && terraform show 
# data.coder_parameter.region:
data "coder_parameter" "region" {
    description = "Which region would you like to deploy to?"
    ephemeral   = false
    form_type   = "input"
    id          = "2aec6abf-883a-4618-98c6-6e262e2bfd9b"
    mutable     = false
    name        = "region"
    optional    = false
    order       = 1
    styling     = jsonencode({})
    type        = "number"
    value       = "nan"
}

@Emyrk Emyrk merged commit 4e7da25 into main Apr 30, 2025
6 checks passed
@Emyrk Emyrk deleted the stevenmasley/more_valid_cases branch April 30, 2025 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants