ci: fix go version to that defined in go.mod #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Sep 5, 2025
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.22" | ||
| go-version: "1.24.2" |
There was a problem hiding this comment.
Why do these need this to be in sync? IIRC Go will run as the version defined in go.mod even if it's a lower version. Higher version of course takes precedence.
See:
~
❯ go1.23.7 version
go version go1.23.7 darwin/arm64
~/Code/coder main*
❯ go1.23.7 version
go version go1.24.6 darwin/arm64
Btw, go.mod says 1.24.6.
There was a problem hiding this comment.
The actions/setup-go action has a breaking change:
Breaking Changes
Improve toolchain handling to ensure more reliable and consistent toolchain selection and management by [@matthewhughes934](https://github.com/matthewhughes934) in [actions/setup-go#460](https://redirect.github.com/actions/setup-go/pull/460)
see #437
There was a problem hiding this comment.
Ah, gotcha, so they're preventing that behavior now.
There was a problem hiding this comment.
#439 stacked the original PR on top and it's green ✅
There was a problem hiding this comment.
Ignore my comment about 1.24.6 btw, originally thought this was a PR to coder/coder repo 😄
mafredri
reviewed
Sep 5, 2025
mafredri
approved these changes
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #437
Our version of Go we reference in our
.github/**doesn't match that ingo.mod.To fix this, I've updated the version of Go and added a check to ensure they're all in sync.
Disclaimer: Most of the script was generated by ChatGPT but I went over it before committing.