Skip to content

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Oct 1, 2025

Update the create logic to warn instead of error when no CODER_TASK_ID is set so that we are backwards compatible.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review October 1, 2025 18:30
Co-authored-by: Cian Johnston <cian@coder.com>
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add an integration test that validates backward compat?

@DanielleMaywood
Copy link
Contributor Author

Can we also add an integration test that validates backward compat?

Can do 👍

@DanielleMaywood
Copy link
Contributor Author

DanielleMaywood commented Oct 2, 2025

So the integration test is kinda messy since we have a chicken-and-the-egg problem of coder/coder not yet supporting the updated resource 😄

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. Once we add support in coder/coder proper then we can update the test.

@DanielleMaywood DanielleMaywood merged commit eb191d3 into main Oct 2, 2025
6 checks passed
@DanielleMaywood DanielleMaywood deleted the danielle/tasks/id-fix branch October 2, 2025 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants