Skip to content

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Feb 21, 2025

I picked up on this reviewing #182, but it's a mistake I made when reviewing the resource originally 😓

There's a minor inconsistency between display names on orgs and some other resources with display names on coderd. i.e. for organizations:

if req.DisplayName == "" {
	req.DisplayName = req.Name
}

For some other resources, e.g. users & groups, an empty string display name is retained, and the CLI/Web UI just shows the actual name if the display name is empty. For those, it's okay to have an empty string default in the provider.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review February 21, 2025 02:50
@ethanndickson ethanndickson merged commit e5afa40 into main Feb 24, 2025
14 checks passed
@ethanndickson ethanndickson deleted the ethan/fix-org-display-name branch February 24, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants