-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for CLI global flag configurations #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
1ad3a20
to
08a2dc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more approval in case you were waiting for one for the most recent changes 😄
#500
Add the settings
coder.globalFlags
to add global flags to allcoder
CLI invocations in VS Code. However, since we already havecoder.headerCommand
which sets the--header-command
, this setting takes precedence over manually entered--header-command
in the global flags settings. Same thing happens for the--global-config
though that one is set internally and not through a setting