Skip to content

Conversation

EhabY
Copy link
Collaborator

@EhabY EhabY commented Sep 2, 2025

#500

Add the settings coder.globalFlags to add global flags to all coder CLI invocations in VS Code. However, since we already have coder.headerCommand which sets the --header-command, this setting takes precedence over manually entered --header-command in the global flags settings. Same thing happens for the --global-config though that one is set internally and not through a setting

@EhabY EhabY requested a review from code-asher September 3, 2025 19:44
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@EhabY EhabY force-pushed the support-cli-global-flags branch from 1ad3a20 to 08a2dc3 Compare September 5, 2025 09:00
@EhabY EhabY requested a review from code-asher September 5, 2025 09:17
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more approval in case you were waiting for one for the most recent changes 😄

@EhabY EhabY merged commit 43ba121 into coder:main Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants