Skip to content

Fix subscriptions not disposed on extension deactivation #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2025
Merged

Fix subscriptions not disposed on extension deactivation #605

merged 3 commits into from
Oct 3, 2025
+344 −329

Conversation

EhabY
Copy link
Collaborator

@EhabY EhabY commented Oct 1, 2025 •
edited
Loading

  • Fix subscriptions not collected
  • Use vscode.workspace.getConfiguration instead of passing a provider
  • Smol simplification of the tsconfig.js for tests

@EhabY EhabY force-pushed the fix-subscriptions-not-disposed branch from 51b8263 to 372a7ee Compare October 1, 2025 08:36
@EhabY EhabY force-pushed the fix-subscriptions-not-disposed branch from e45b6b8 to 9e08d64 Compare October 2, 2025 09:33
@EhabY EhabY requested a review from code-asher October 2, 2025 12:18
code-asher
code-asher approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@EhabY EhabY merged commit 4600567 into coder:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EhabY @code-asher