Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to golang.org/x/term #21

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Switch to golang.org/x/term #21

merged 1 commit into from
Dec 2, 2020

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Nov 29, 2020

The godoc for golang.org/x/crypto/ssh/terminal indicates that the
package is deprecated, moved to golang.org/x/term.

This PR changes the import from golang.org/x/crypto/ssh/terminal to golang.org/x/term and also usages from terminal to term. I'm currently on Windows, so have not tested this change, though it seems pretty straightforward to me. I also ran go mod tidy to update go.mod/go.sum.

The godoc for golang.org/x/crypto/ssh/terminal indicates that the
package is deprecated, moved to golang.org/x/term.
@greyscaled greyscaled requested a review from cmoog December 1, 2020 02:44
Copy link
Contributor

@cmoog cmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmoog cmoog merged commit 3ada696 into coder:master Dec 2, 2020
@jawnsy jawnsy deleted the switch-term branch December 3, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants