Feature/weather fields

[sebastinto]

Summary

This PR enhances the weather command with customizable field selection, allowing users to specify exactly which weather information they want to see.

Key Features

• Customizable Field Selection: Users can now tailor the weather output by specifying desired fields (e.g. weather denver -temp -humidity).
• Extensive & Extensible Data Points: 38 weather fields organized into categories (current, forecast, air quality, astronomy) were implemented. Full integration should be easy to implement in the future if desired.
• Weather Command Helper: The weather list command displays all available fields and their categories.
• Robust Parsing: Improved command parsing with detailed error messages for invalid syntax or field combinations.
• Internationalization: Full support for 6 languages across all new functionalities.
• Thorough Testing: Comprehensive coverage with 6 test suites addressing various scenarios and edge cases + manual testing performed.

Examples: weather london -temp -humidity, weather paris -uv -wind, weather winston-salem -sunrise -sunset, weather list

Technical Changes

While the primary goal was to maintain consistency with existing codebase patterns, the complexity of the customizable field selection feature necessitated strategic deviation in specific areas:

• Ktor Adoption: Introduced for its native coroutine support, enabling seamless asynchronous operations for API calls. Ktor's built-in content negotiation simplifies JSON handling, and its structured exception handling integrates effectively with the new field validation system.
• kotlinx.serialization Integration: Chosen for compile-time safety in data models and automatic null handling for optional API fields. This significantly reduces boilerplate code, especially when managing the 38 field structures required for selective display.
• More Granular Code Organization: To manage the complexity introduced by field selection, specialized components have been organized into distinct files (WeatherValidation.kt, WeatherField.kt, WeatherModels.kt, WeatherRenderer.kt, etc.), keeping the main Command.kt file focused on its core responsibilities.

These changes were applied judiciously, only where feature requirements provided a clear benefit, while diligently preserving the codebase's established conventions elsewhere.

Testing

In addition to the unit tests, please review the screenshots below:

[sebastinto]

Any comments, suggestions, questions are welcome. As mentioned in the PR, I tried to follow the existing coding style as much as possible but in a few instances I felt like the features required a different approach. Happy to discuss!

I tried to cover as much ground as possible during testing but obviously another set of eyes would be appreciated to catch edge cases I may have overlooked. Thanks!

[coderGtm]

Hey @sebastinto

This is a superb enhancement to the command. I have not reviewed the code changes yet but visually it looks perfect!

Thank you for showing interest in contributing to the launcher. Will get this feature fast-tracked to the release!

[Copilot]

Pull Request Overview

This PR introduces comprehensive customizable field selection for the weather command, allowing users to specify exactly which weather information they want to see. The PR transforms the basic weather command into a flexible tool with 38 available fields organized into categories (current, forecast, air quality, astronomy).

Key changes:

• Implements field-specific weather reporting with -field syntax (e.g., weather london -temp -humidity)
• Migrates from Volley to Ktor with kotlinx.serialization for better type safety and coroutine support
• Adds comprehensive validation system with detailed error messages in 6 languages

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
Command.kt	Main command logic refactored to use new parsing and Ktor HTTP client
WeatherValidation.kt	New comprehensive validation system for weather command parsing
WeatherField.kt	Weather field definitions and rendering logic for 38 available fields
WeatherModels.kt	Data models for WeatherAPI response using kotlinx.serialization
WeatherRenderer.kt	UI rendering utilities for field listings and error messages
Helper.kt	Network handling with Ktor, error processing, and response formatting
strings.xml files	Extensive localization additions for new features across 6 languages
build.gradle	Dependencies added for Ktor and kotlinx.serialization
Test files	Comprehensive test coverage with 6 test suites for validation logic

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coderGtm]

Great work @sebastinto 🫡
A very comprehensive PR. I got to learn a lot!

LGTM