-
Notifications
You must be signed in to change notification settings - Fork 6
Preview/shopify theme #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0955e19
Shopify theme files
nimratcoderabbit 7c5ef19
Fixing path
nimratcoderabbit fcd68e0
fix config
alexcoderabbitai 483cfb5
allow all
alexcoderabbitai 1c8b8be
fix themecheck config
alexcoderabbitai 9c9cf95
test with full layout
alexcoderabbitai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
reviews: | ||
path_filters: ["**/*","*.*"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Explicitly enable all checks (by default, all are enabled) | ||
checks: | ||
all: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* CSS with deliberate issues */ | ||
body { | ||
font-family: Arial sans-serif /* Missing comma between fonts and no semicolon */ | ||
color: #333 | ||
} | ||
.invalid-selector { | ||
--unknown: 123 /* Invalid property/value syntax */ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// JavaScript with syntax errors | ||
function initTheme() { | ||
console.log("Initializing theme... // Missing closing quote and parenthesis | ||
} | ||
|
||
initTheme(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
[ | ||
{ | ||
"name": "General", | ||
"settings": [ | ||
{ | ||
"type": "text", | ||
"id": "title", | ||
"label": "Store Title", | ||
"default": "My Shopify Store", | ||
} // Trailing comma causes invalid JSON | ||
] | ||
} | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<title>{{ page_title </title> {# Missing closing curly brace and invalid Liquid tag #} | ||
{{ 'style.css' | asset_url | stylesheet_tag }} | ||
</head> | ||
<body> | ||
{% include 'header' %} {# Assume this is meant to call a section/snippet but syntax might be off #} | ||
{{ content_for_layout } | ||
{% include 'footer' %} | ||
{{ 'theme.js' | asset_url | script_tag }} | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"general": { | ||
"welcome": "Welcome to our store!", // Trailing comma causes invalid JSON | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<footer> | ||
<p>© {{ 'now' | date: "%Y" }} My Shopify Store</p> | ||
<p>Contact us at email@example.com {# Missing closing tag or unexpected text #} | ||
</footer> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<header> | ||
<h1>{{ settings.title }</h1> {# Missing closing double curly brace on settings.title #} | ||
<nav> | ||
<ul> | ||
<li><a href="/collections/all">Products</a></li> | ||
<li><a href="/about-us">About Us</a></li> | ||
<!-- Missing closing </ul> tag --> | ||
</nav> | ||
</header> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<div class="product-card"> | ||
<h2>{{ product.title </h2> {# Missing closing curly brace for product.title #} | ||
<p>Price: {{ product.price | money }}</p | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{% section 'header' %} | ||
<main> | ||
<h2>Featured Products</h2> | ||
{% for product in collections.frontpage.products %} | ||
{% include 'product-card' {# Missing closing %} tag #} | ||
{% endfor %} | ||
</main> | ||
{% section 'footer' {# Using "section" instead of include for footer, and missing closing %} #} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{% section 'header' %} | ||
<main> | ||
<article> | ||
<h1>{{ product.title }}</h1> | ||
<div>{{ product.description {# Missing closing curly brace #} | ||
</article> | ||
</main> | ||
{% section 'footer' %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration key likely unsupported – switch to official format
The Shopify Theme Check gem does not recognize a
checks: all: true
stanza.To enable all checks you normally either omit the file entirely (the default) or use
extends: all
(or the newerThemeCheck: extends:
syntax). Keeping the current block will silently be ignored and you’ll think the linter is active when it isn’t.Add a trailing newline as flagged by yamllint.
📝 Committable suggestion
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 3-3: no new line character at the end of file
(new-line-at-end-of-file)
🤖 Prompt for AI Agents