wrong ServiceWorker script path when using prefix

[panlina]

Hi,
I'm using cloudcmd behind a proxy, so I set prefix to "/cloudcmd", then I found that the browser console gave an error saying:

Failed to register a ServiceWorker: The origin of the provided scriptURL ('https://cloudcmd') does not match the current origin

Digging into the source I found this line of code:

cloudcmd/client/sw/register.js

Line 9 in 15abcee

prefix = prefix ? `/${prefix}/` : `/`;

From example code in this repo I believe prefix is supposed to contain the leading slash(/). If that's true, prefix will become "//cloudcmd/" and the script path to register will become "//cloudcmd/sw.js":

cloudcmd/client/sw/register.js

Line 22 in 15abcee

return navigator.serviceWorker.register(`${prefix}sw.js`);

That's exactly how the 'https://cloudcmd' in the error message comes in. Obviously the intended path is "/cloudcmd/sw.js", so I believe `/${prefix}/` should be `${prefix}/`.
Am I right?

[coderaiser]

Yes you right, thank you :), fixed with b5f9261, landed in v11.2.2 🎉

[panlina]

It's fixed. Thanks for your quick fix. 😄