Update deprecated getters and setters #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Marius, Thanks for your support! As per the recent build release notes, it looks like the client* and offset* attributes has been converted to rects.
Can you make the necessary changes? Also, please update the AUTHORS file with your name Thanks. |
This reverts commit 71cb47e. Actually replaced the deprecated api with an internal implementation that is not the official way.
This reverts commit 9c1328a.
This reverts commit 996058c.
https://groups.google.com/a/dartlang.org/forum/#!msg/misc/bavhE6GlM7E/d6ifDYps7CcJ Element.client*, Element.offset* have become rects so the correct syntax is now Element.client.* and Element.offset.*
https://groups.google.com/a/dartlang.org/forum/#!msg/misc/bavhE6GlM7E/d6ifDYps7$ inputEvent.page* and inputEvent.offset* are now dperecated and use point instead. The correct usage is now inputEvent.page.* and inputEvent.offset.* respectively
https://groups.google.com/a/dartlang.org/forum/#!msg/misc/bavhE6GlM7E/d6ifDYps7$ List.getRange() has been deprecated and will be removed. The new usage is List.sublist(). The second paramter is now also a length rather than an ending index.
|
Hi Ali, Awesome library here! I wanted to thank you for you encouraging feedback and information - it makes me want to continue contributing to open-source projects. Best regards, |
coderespawn
added a commit
that referenced
this pull request
Mar 22, 2013
Update deprecated getters and setters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Element abstract class had some changes made to it that deprecated the old way of calling getters and setters. The new way has a "$dom_" prefix.
This commit updates these calls for lib and for the IDE sample.