Skip to content

Conversation

coderofstuff
Copy link
Owner

Process signing input from deserialize to signing

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 84.01% and project coverage change: -1.70 ⚠️

Comparison is base (9f76723) 89.63% compared to head (d92cd44) 87.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   89.63%   87.94%   -1.70%     
==========================================
  Files          23       25       +2     
  Lines         965     1178     +213     
==========================================
+ Hits          865     1036     +171     
- Misses        100      142      +42     
Flag Coverage Δ
unittests 87.94% <84.01%> (-1.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/transaction/deserialize.c 67.30% <63.33%> (-6.61%) ⬇️
src/import/blake2b.c 72.05% <72.05%> (ø)
unit-tests/test_sighash.c 96.42% <88.88%> (+4.42%) ⬆️
src/sighash.c 95.76% <98.86%> (+0.57%) ⬆️
src/import/blake2-impl.h 100.00% <100.00%> (ø)
unit-tests/test_tx_parser.c 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@coderofstuff coderofstuff merged commit d5a67e4 into main Apr 22, 2023
@coderofstuff coderofstuff deleted the wire-sighash-sign branch April 22, 2023 23:22
@coderofstuff coderofstuff self-assigned this Apr 23, 2023
coderofstuff pushed a commit that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants