Install and configure Google Cloud SDK #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlocher
changed the title
mlocher
force-pushed
the
google-cloud-sdk
branch
from
9990fac to
0cf2908
Compare
sromocki
pushed a commit
to kevy/scripts
that referenced
this pull request
Feb 6, 2016
Upping elasticsearch version [#110561816]
joesiewert
force-pushed
the
google-cloud-sdk
branch
2 times, most recently
from
8ce4346 to
2a4223a
Compare
joesiewert
force-pushed
the
google-cloud-sdk
branch
from
2a4223a to
82d7652
Compare
|
Ready for another look @mlocher. |
|
can't approve, as I'm one of the authors :D, looks great though. Two things we might want to keep in mind and address in a future PR
@ethangj could you take a look? |
|
great we finally got the PR #1 shipped (and a little sad it took that long to get it finished). Thanks @joesiewert for taking over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft, installation works, but the authentication hasn't been tested yet. To upgrade to a newer version you need to reset the dependency cache on Codeship.