Improve build path for ajax request #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
#29_read_the_path_from_the_admin_resource
branch
6 times, most recently
from
33ddbbf to
8b224b6
Compare
Ivanov-Anton
force-pushed
the
#29_read_the_path_from_the_admin_resource
branch
3 times, most recently
from
f3283be to
cd8beef
Compare
|
@tf Best Tim |
added 2 commits
February 4, 2021 12:35
To prevent error in build path for ajax request when we have namespaced classes solves codevise#29 issue
Ivanov-Anton
force-pushed
the
#29_read_the_path_from_the_admin_resource
branch
from
cd8beef to
fac26c8
Compare
Adapt test case for namespaced module to actually fetch the options to ensure that the constructed route actually works.
No need to fall back to constructing it via `polymorphic_path` since if we cannot fine the admin resource to get `route_collection_path`, we will also not be able to use to determine `ajax_resource_class`.
|
I pushed two changes: One to align the new end to end test with the way the existing one worked. And another to simplify the construction of the route. Can you check if I broke anything in your setup? |
|
Good job Tim |
|
@tf, I have no more offers, everything is fine |
|
Great! Released as 1.4. Thank you for your work on this issue! 🎉 |
glebtv
pushed a commit
to rs-pro/activeadmin-tom_select
that referenced
this pull request
Aug 19, 2025
…om_the_admin_resource Improve build path for ajax request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent error in build path for ajax request when we have namespaced classes
solves #29 issue