Fix Demeter violations in ZencoderVideoOutputDefinition

Introduce `VideoFile#encode_highdef?` method to remove duplication of
feature name.

app/models/pageflow/video_file.rb

@@ -43,6 +43,10 @@ def attachment_s3_url
       "s3://#{File.join(attachment_on_s3.bucket_name, attachment_on_s3.path)}"
     end
 
+    def encode_highdef?
+      entry.feature_state('highdef_video_encoding')
+    end
+
     def mp4_4k
       ZencoderAttachment.new(self, '4k.mp4')
     end

lib/pageflow/zencoder_video_output_definition.rb

@@ -34,7 +34,7 @@ def outputs
     private
 
     def mp4_highdef_definitions
-      return [] unless video_file.entry.feature_state('highdef_video_encoding')
+      return [] unless video_file.encode_highdef?
       [transferable(mp4_4k_definition), transferable(mp4_fullhd_definition)]
     end
 
@@ -128,7 +128,7 @@ def dash_definitions
     end
 
     def dash_highdef_definitions
-      return [] unless video_file.entry.feature_state('highdef_video_encoding')
+      return [] unless video_file.encode_highdef?
 
       [
         non_transferable(dash_fullhd_definition),
@@ -149,7 +149,7 @@ def hls_definitions
     end
 
     def hls_highdef_definitions
-      return [] unless video_file.entry.feature_state('highdef_video_encoding')
+      return [] unless video_file.encode_highdef?
 
       [
         non_transferable(hls_fullhd_definition),
@@ -257,7 +257,7 @@ def dash_stream_definitions
     end
 
     def dash_highdef_stream_definitions
-      return [] unless video_file.entry.feature_state('highdef_video_encoding')
+      return [] unless video_file.encode_highdef?
       [
         {
           source: 'dash-fullhd',
@@ -367,7 +367,7 @@ def hls_stream_definitions
     end
 
     def hls_highdef_stream_definitions
-      return [] unless video_file.entry.feature_state('highdef_video_encoding')
+      return [] unless video_file.encode_highdef?
       [
         {
           source: 'hls-fullhd',
@@ -404,7 +404,7 @@ def smil_definitions
       # these cases the input file is just a tiny bit larger than the
       # next lower resolution, so we do not really care if the SMIL
       # file which does not include the higher quality does not win.
-      if video_file.entry.feature_state('highdef_video_encoding')
+      if video_file.encode_highdef?
         [
           non_transferable(smil_definition.merge(streams: smil_default_stream_definitions,
                                                  skip: {

spec/models/pageflow/video_file_spec.rb

@@ -39,5 +39,19 @@ module Pageflow
         expect(video_file.present_outputs).to include(:'hls-playlist')
       end
     end
+
+    describe '#encode_highdef?' do
+      it 'returns false by default' do
+        video_file = build(:video_file)
+
+        expect(video_file.encode_highdef?).to eq(false)
+      end
+
+      it 'returns true if entry has highdef_video_encoding feature enabled' do
+        video_file = build(:video_file, :with_highdef_encoding)
+
+        expect(video_file.encode_highdef?).to eq(true)
+      end
+    end
   end
 end