Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic tests for UsersTab add user button #805

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Basic tests for UsersTab add user button #805

merged 2 commits into from
Aug 15, 2017

Conversation

aviav
Copy link
Contributor

@aviav aviav commented Jul 26, 2017

No description provided.

@aviav aviav assigned tf Jul 26, 2017
houndci-bot
houndci-bot reviewed Jul 26, 2017
View reviewed changes
spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb

module Pageflow
module Admin
describe AddMembershipButtonIfNeeded, type: :view_component do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [27/25]

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.045% when pulling 018d2ea on aviav:add-membership-button-first-specs into 966a98f on codevise:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.045% when pulling 018d2ea on aviav:add-membership-button-first-specs into 966a98f on codevise:master.

@aviav aviav assigned aviav and unassigned tf Jul 26, 2017
@aviav aviav changed the title Basic tests for UsersTab add user button [WIP] Basic tests for UsersTab add user button Jul 26, 2017
@aviav aviav force-pushed the add-membership-button-first-specs branch from 018d2ea to 696518a Compare July 26, 2017 15:24
houndci-bot
houndci-bot reviewed Jul 26, 2017
View reviewed changes
spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb

module Pageflow
module Admin
describe AddMembershipButtonIfNeeded, type: :view_component do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [33/25]

@coveralls
Copy link

coveralls commented Jul 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.069% when pulling 696518a on aviav:add-membership-button-first-specs into dfc049d on codevise:master.

@aviav aviav assigned tf and unassigned aviav Jul 26, 2017
@aviav aviav changed the title [WIP] Basic tests for UsersTab add user button Basic tests for UsersTab add user button Jul 26, 2017
tf
tf requested changes Jul 26, 2017
View reviewed changes
spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb Outdated
helper.extend(ActiveAdmin::ViewHelpers)
helper.extend(Pageflow::Admin::MembershipsHelper)
allow(helper).to receive(:new_admin_account_membership_path)
allow(helper).to receive(:membership_possible_for)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

membership_possible_for is a private method of the view component not a helper method. Does this allow do anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well as with url_for, the exception backtrace changed. The individual specs did already pass without these calls, and maybe running the test suite again I will find that having url_for stubbed makes the suite pass already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running bin/rspec. This line is indeed not needed

spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb
before do
helper.extend(ActiveAdmin::ViewHelpers)
helper.extend(Pageflow::Admin::MembershipsHelper)
allow(helper).to receive(:new_admin_account_membership_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't stubbing url_for enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running bin/rspec. This line is needed

@tf tf assigned aviav and unassigned tf Jul 26, 2017
@tf tf changed the title Basic tests for UsersTab add user button [WIP] Basic tests for UsersTab add user button Jul 26, 2017
@aviav aviav force-pushed the add-membership-button-first-specs branch from 696518a to 81e8c5b Compare August 1, 2017 16:19
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.069% when pulling 81e8c5b on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.069% when pulling 81e8c5b on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

@aviav aviav force-pushed the add-membership-button-first-specs branch from 81e8c5b to 5917c8e Compare August 1, 2017 17:22
houndci-bot
houndci-bot reviewed Aug 1, 2017
View reviewed changes
spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb

module Pageflow
module Admin
describe AddMembershipButtonIfNeeded, type: :view_component do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [58/25]

@aviav aviav force-pushed the add-membership-button-first-specs branch from 5917c8e to ce3cc91 Compare August 1, 2017 17:25
houndci-bot
houndci-bot reviewed Aug 1, 2017
View reviewed changes
spec/views/components/pageflow/admin/add_membership_button_if_needed_spec.rb

module Pageflow
module Admin
describe AddMembershipButtonIfNeeded, type: :view_component do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [59/25]

@aviav aviav force-pushed the add-membership-button-first-specs branch from ce3cc91 to 824c8e4 Compare August 1, 2017 17:28
@aviav aviav changed the title [WIP] Basic tests for UsersTab add user button Basic tests for UsersTab add user button Aug 1, 2017
@aviav aviav assigned tf Aug 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 99.048% when pulling 824c8e4 on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 99.048% when pulling 824c8e4 on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

@coveralls
Copy link

coveralls commented Aug 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.07% when pulling 824c8e4 on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

@coveralls
Copy link

coveralls commented Aug 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.07% when pulling 824c8e4 on aviav:add-membership-button-first-specs into 48b540b on codevise:master.

@tf tf modified the milestone: v12.1 Aug 11, 2017
@aviav aviav force-pushed the add-membership-button-first-specs branch from 824c8e4 to 6f54458 Compare August 13, 2017 19:29
@coveralls
Copy link

coveralls commented Aug 13, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.063% when pulling 6f54458 on aviav:add-membership-button-first-specs into 3d34806 on codevise:master.

@tf tf unassigned tf and aviav Aug 14, 2017
@tf tf merged commit 154b9d5 into codevise:master Aug 15, 2017
tilsammans added a commit to scrollytelling/app that referenced this pull request Nov 12, 2017
@tilsammans
upgrade Pageflow
0dc025e 
2017-11-07

[Compare changes](codevise/pageflow@12-0-stable...v12.1.0)

- Include HLS in output presences of legacy files
  ([#872](codevise/pageflow#872),
   [#867](codevise/pageflow#867))

  The database migration for Pageflow 12.0 which updates output
  presences of existing video files is missing the HLS variant. This
  causes HLS urls of existing video files to be rendered as
  `undefined`.

  To apply the fix, install migrations and migrate your database. This
  fix has previously been released as part of version 12.0.2.

- Add Resque::Server to the generated routes
  ([#871](codevise/pageflow#871))

  Mounting the Resque web server makes it easier to inspect background
  workers and restart jobs that have failed. See the issue description
  of [#856](codevise/pageflow#856) on how to
  add this to existing apps.

- The theme configured on account level now only acts as a default for
  new entries. After enabling the `selectable_themes` feature, a theme
  selection dialog is available inside the editor from the "Title and
  Options > Appearance" tab. The dialog allows configuring the theme
  on a per revision basis.
  ([#781](codevise/pageflow#781),
   [#897](codevise/pageflow#897))

- Use page from url hash es landing page
  ([#832](codevise/pageflow#832))
- Do not record history when changing pages via scrolling
  ([#831](codevise/pageflow#831))
- Improve text tracks and info box display logic
  ([#826](codevise/pageflow#826))
- Bug fix: Fix order of public i18n fallback
  ([#883](codevise/pageflow#883))
- Bug fix: Prevent display of NaN duration in video controls
  ([#878](codevise/pageflow#878))
- Bug fix: Prevent 404 when share image has been deleted
  ([#816](codevise/pageflow#816))

- Use searchable select boxes in admin forms
  ([#888](codevise/pageflow#888))
- Remove sensitive data from active admin downloads
  ([#899](codevise/pageflow#899))
- Add config option to prevent multi account users
  ([#848](codevise/pageflow#848),
   [#868](codevise/pageflow#868))
- Add config options to restrict account manager permissions
  ([#849](codevise/pageflow#849))
- Fix N+1 query in account admin users tab
  ([#877](codevise/pageflow#877))
- Bug fix: Hide restore link and snapshot button for entry previewers
  ([#853](codevise/pageflow#853))
- Bug fix: Use copy of current_user in profile form
  ([#850](codevise/pageflow#850))
- Bug fix: Ensure new entry button is hidden for editors
  ([#847](codevise/pageflow#847))
- Bug fix: Show folder edit button only for publishers and above
  ([#838](codevise/pageflow#838))
- Bug fix: Allow :create entry only for publishers on accounts, not on entries
  ([#836](codevise/pageflow#836))

- Widget configuration
  ([#694](codevise/pageflow#694),
   [#809](codevise/pageflow#809))
- Bug fix: Ensure page order in editor preview stays up to date
  ([#898](codevise/pageflow#898))
- Bug fix: Switch off file meta data edit links when uploading
  ([#857](codevise/pageflow#857))
- Bug fix: Improve polling for HostedFile state
  ([#822](codevise/pageflow#822))
- Bug fix: Handle undefined page title.
  ([#763](codevise/pageflow#763))

- Use relative urls inside dash and hls playlists
  ([#842](codevise/pageflow#842))
- Use web audio api for volume fading if available
  ([#800](codevise/pageflow#800),
   [#863](codevise/pageflow#863))

- Add panorama_mask image file style
  ([#830](codevise/pageflow#830))
- Bug fix: Make url template generation more robust
  ([#876](codevise/pageflow#876))

- Themes can now be guarded by feature flags
  ([#765](codevise/pageflow#765))
- Extend EncodingConfirmation by public account attribute
  ([#817](codevise/pageflow#817))
- Extend query interface
  ([#815](codevise/pageflow#815))
- Accept options for accounts admin menu via config
  ([#811](codevise/pageflow#811))
- Add placeholder options to textareainputview
  ([#807](codevise/pageflow#807))
- Call hook on entry publication
  ([#806](codevise/pageflow#806))
- Add rake task and resque job to delete old auto snapshots
  ([#861](codevise/pageflow#861),
   [#882](codevise/pageflow#882))
- Generate a secure password in the seeds
  ([#775](codevise/pageflow#775))

- Allow specifying opacity of image variant logo
  ([#799](codevise/pageflow#799))
- Allow setting size of custom loading spinner background
  ([#798](codevise/pageflow#798))
- Add theme option to right align logo in desktop layout
  ([#797](codevise/pageflow#797))
- Add theme option to hide scroll indicator
  ([#790](codevise/pageflow#790))
- Make content text max width configurable
  ([#780](codevise/pageflow#780),
   [#804](codevise/pageflow#804))

- Import nginx-upload-module guide from wiki
  ([#814](codevise/pageflow#814),
   [#821](codevise/pageflow#821))
- Add documentation for versioning policy
  ([#866](codevise/pageflow#866))
- Fix small typos
  ([#787](codevise/pageflow#787))

- Precompile assets in Travis run
  ([#873](codevise/pageflow#873))
- Test workflow improvements
  ([#803](codevise/pageflow#803))
- Generate admins with account membership in specs
  ([#840](codevise/pageflow#840))
- Use rails 4.2.9 in tests
  ([#837](codevise/pageflow#837))
- Clean up memberships admin code
  ([#835](codevise/pageflow#835))
- Basic tests for UsersTab add user button
  ([#805](codevise/pageflow#805))
- Use codevise/teaspoon for logging backtraces on console
  ([#786](codevise/pageflow#786))
- Split vendored code from our own
  ([#885](codevise/pageflow#885))
- Introduce ApplicationRecord
  ([#889](codevise/pageflow#889))
- Move configuration into a concern
  ([#794](codevise/pageflow#794))
- Read the attribute instead of super
  ([#810](codevise/pageflow#810))
- Destroy widgets when parent subject is destroyed
  ([#834](codevise/pageflow#834))
- Fix dummy app generation on Travis for Rubygems 2.7
  ([#893](codevise/pageflow#893))
- Update contents of gemspec
  ([#891](codevise/pageflow#891))
- Bug fix: Work around breaking change in resque_mailer 2.4.3
  ([#894](codevise/pageflow#894))

See
[12-0-stable](https://github.com/codevise/pageflow/blob/12-0-stable/CHANGELOG.md)
branch for previous changes.
@tilsammans tilsammans mentioned this pull request Nov 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@tf tf tf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@aviav @coveralls @tf @houndci-bot