Extend query interface

[aviav]

• Introduce AccountRoleQuery
• Introduce AccountMemberQuery
• Make AccountMemberQuery and EntryRoleQuery depend on ApplicationQuery

[houndci-bot]

Block has too many lines. [39/25]

[houndci-bot]

Block has too many lines. [41/25]

[houndci-bot]

Block has too many lines. [38/25]

[houndci-bot]

Block has too many lines. [40/25]

[houndci-bot]

Block has too many lines. [42/25]

[coveralls]

Coverage decreased (-0.001%) to 99.066% when pulling 592fc11 on aviav:extend-query-interface into 22d7968 on codevise:master.

[tf]

In the YARD doc they use [] for types. This is inconsistent in other files as well, but let's try to be consistent.

[tf]

This works but does not read well. Let's be explicit and write ApplicationQuery::Scope.

[tf]

private stuff (in the Ruby sense) is @api private by default.

[tf]

@api protected is not a thing so far. Let's make ApplicationQuery @api private completely since we do not expect anyone to inherit from it.

[tf]

I think, FolderPolicy could also benefit from using the query. Please check if some these _or_above methods on Membership are unused then and can be removed.

[aviav]

EDIT: Disregard the following two comments. I think adding a Scope is the way to go here:

Would this be okay in principle? Would we want to catch the error/throw something else?

    def has_at_least_role?(role, on_as_many_accounts_as: 1)
      case on_as_many_accounts_as
      when 0
        does_not_have_role?(role)
      when 1
        has_role_at_least_once?(role)
      else
        if on_as_many_accounts_as > 1
          has_role_at_least?(role, on_as_many_accounts_as)
        else
          raise ArgumentError('Integer 0 or greater expected for '\
                              'on_as_many_accounts_as')
        end
      end
    end

[aviav]

(We would need on_as_many_accounts_as: 2 for now, but doing it for 1 and 2 only seems excessively lazy)

Also, the other methods are supposed to be private, so the ambiguous naming is okay because of context and because long method names impede reading

Specific usage:

    def show_account_selection_on?
      (@user.admin? && Account.all.size > 1) ||
        query.has_at_least_role?(:publisher, on_as_many_accounts_as: 2)
    end

[aviav]

Adding the Scope requires specs and maybe thought, so I will leave it for the next apparent opportunity. I agree, however, that we can probably use the extended query interface in other policies as well and thus improve readability, design and such

[tf]

Please also add a one line doc comment to the query classes themselves.

[coveralls]

Coverage decreased (-0.0004%) to 99.066% when pulling 610dad7 on aviav:extend-query-interface into 22d7968 on codevise:master.

[coveralls]

Coverage decreased (-0.0004%) to 99.066% when pulling 610dad7 on aviav:extend-query-interface into 22d7968 on codevise:master.

[coveralls]

Coverage decreased (-0.001%) to 99.059% when pulling 59ae2ef on aviav:extend-query-interface into 3d34806 on codevise:master.