Improve text tracks and info box display logic #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure info box elements are not displayed if the corresponding props only contain empty strings.
Move text tracks up immediately when player controls are displayed, but only move them back down on next cue change when player controls are hidden again. When player controls are displayed, we have no other chance than moving the text tracks directly since they would otherwise be hidden by the player controls. After the player controls are hidden again, we can wait for the user to finish reading the current cue and only then move text tracks back down.
Let other components determine whether an info box will be displayed.
Allow passing a custom `className` and mouse enter/mouse leave event handlers.
* Add `infoBoxHiddenDuringPlayback` flag to state which can be controlled via actions. * Hide info box directly if text tracks are enabled. * Remove `has_been_faded` css class which is now unused.
Prevent player controls from fading too quickly after the page has been entered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #826