-
Notifications
You must be signed in to change notification settings - Fork 234
Getting started: solving kata #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ugh, the output of TextLint is not helpful. I'll look for a way to integrate with GitHub Actions better, but you have a misspelled word on line 23. |
Yeah it's kinda confusing, but until now I somehow managed to understand it. I will fix the typo tomorrow |
there was still no preview available, so I made a small change/commit. changed:
to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I'd like a screenshot of the trainer, in the Kata trainer section. Even a small one. Without it, being a new user, I wouldn't get what the documentation is talking about (picture prefereably before the explainations?)
-
Overwhole, this is a huge section. By far too much, imo. I feel like the parts about honor and ranks should be in another page. They aren't about "solving" the task, but rather "what happens next". Might be a good idea to rename
Viewing Solutions
to something likeOnce you solved a Kata
, which would be talking about:- rewards
- feedback
-
About "when the tests fail over again" and "unlocking solutions":
- unlocking might lay into the current page because of the related button. But then I'd put it after the "submit final" section. Note:
## Unlocking solutions
, in this case, not# Un...
- the trouble shooting part doesn't really feel right in this page. It's related to solving, yeah, for sure. I feel like if it's the last section of the page it's ok (then: submit final -> unlock -> trouble shooting -> end)
- unlocking might lay into the current page because of the related button. But then I'd put it after the "submit final" section. Note:
-
General tip: You tend to write one single § in the small sections while you almost always have an short introductory sentence at the beginning. => split it into 2 different §. ;)
-
Question: you tend to not use articles before nouns:
...right. Output panel...
while I'd naturally write it as...right. The output panel...
. Is that my french that is making me whish for wrong things or is that your polish at stake? XD
|
||
### Solution editor | ||
|
||
You use solution editor to write code which solves the task. You can type the code straight into the editor, but if you want, you can use your favorite IDE and just copy your solution from it and paste it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linefeed+others
You use solution editor to write code which solves the task. You can type the code straight into the editor, but if you want, you can use your favorite IDE and just copy your solution from it and paste it here. | |
You use solution editor to write code which solves the task. | |
You can type the code straight into the editor, but if you want, you can use your favorite IDE and just copy your solution from it and paste it here (just don't forget to copy the imports if your language needs some!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About "when the tests fail over again" and "unlocking solutions":
- unlocking might lay into the current page because of the related button. But then I'd put it after the "submit final" section. Note:
## Unlocking solutions
, in this case, not# Un...
- the trouble shooting part doesn't really feel right in this page. It's related to solving, yeah, for sure. I feel like if it's the last section of the page it's ok (then: submit final -> unlock -> trouble shooting -> end)
I was trying to follow the "natural" flow of the way how newbie would go through a kata:
- write solution,
- Run sample tests
- Run full tests, which potentially fail many times,
- Go search for help,
- Unlock solutions when nothing helps
Order of headers follows this process, which I think is natural and different order seems a bit off to me.
|
||
### Test | ||
|
||
This button will test your solution against the _sample_ tests. Most kata will have provided you some sample tests to get you going, while others will not, in which case some test documentation will be shown instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linefeed+others
This button will test your solution against the _sample_ tests. Most kata will have provided you some sample tests to get you going, while others will not, in which case some test documentation will be shown instead. | |
This button will test your solution against the _sample_ tests. | |
Most kata will have provided you with some example tests to get you going, while others will not, in which case some default documentation will be shown instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this page is getting too long.
Rewards should definitely go to a separate page.
We should create a page on how to communicate about kata and Feedback can go there.
Unlocking can be briefly mentioned, but maybe linking to a dedicated page explaining the details is better.
Added link to TDD article on Wikipedia Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>
Co-authored-by: kazk <kazk.dev@gmail.com>
I split "solving" and "solved" parts into two separate pages. Please let me know what you think. |
…ewars/docs into getting_started-solving_kata
|
Done
It got submitted accidentally, sorry. It's to be removed.
Does it work already? |
actually yes. I forgot to update the title of the section... XD (corrected) (edit: I'll try it...) EDIT²: I just checked, that's ok with the info in #74 and the pictures stored in the |
Maybe change the title of the new page to "When kata get solved"? (because other titles are plural, that looks a bit weird in the sidebar) |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better document the task and not the buttons.
When you're documenting tasks that involve the user interface (UI), focus on the task, not how the user interacts with the UI element.
https://developers.google.com/style/ui-elements
So instead of Test
or Test Button
, make the section heading something like Test against the sample tests
. Explain that sample tests are for you to edit and test against while writing the solution.
Instead of Attempt
of Attempt Button
, make the next section heading something like Attempt the full tests
. Explain the difference between the full and the sample.
We can improve this later after merging this if you want.
@hobovsky You can merge this if you want. I already left my review yesterday. #72 (review) |
I've already started working on your suggestions, so if you'd want to review my updates, then go ahead, and if you think it;s ok, you can merge it. I will get back to it tomorrow, so if you still think things are good, I will merge my changes. But you can still leave some remarks if you have any, or just merge if you think all is ok. |
Co-authored-by: kazk <639336+kazk@users.noreply.github.com>
Co-authored-by: kazk <639336+kazk@users.noreply.github.com>
Co-authored-by: kazk <639336+kazk@users.noreply.github.com>
Please take a look if it goes in good direction. I am wondering if it needs screenshots, or links to UI docs will suffice?