Update "expect_no_error" to report raised exceptions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kazk could you take a look at this PR when you have time? I've created it because some kata was silently consuming errors with no feedback, and now the same issue appeared here. It'd be better if this was fixed in the framework itself, instead of raising the same issue and copy-pasting the same fix in every kata requiring the |
kazk
approved these changes
Apr 22, 2020
|
I'll update Python 3.6 and let you know when it's deployed. |
|
Deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
expect_no_errorsilently consumes any exceptions raised in the code, the user may have no information about what's happening or why some particular test failed. Normally, authors have to specify a custom error message to avoid this, but this is not the case with thetimeoutdecorator: it delegates execution toexpect_no_errorwhile catching all exceptions with a useless"Should not throw any exception inside timeout"error message. This quick fix should make timed blocks more informative on failure, and provide some minimal info if an empty string is passed as themessageargument.