Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-04282 refactor Data Validation documentation #4283

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

ricklarsen
Copy link

@ricklarsen ricklarsen commented Jan 30, 2019

What does this PR do?

  • Removes the section "Data and Metadata" from the Integrating section of the documentation.
  • content moved to Architecture Reference and Managing/Data Management sections as appropriate.

Who is reviewing it?

@ahoffer @austinsteffes

Select relevant component teams:

@codice/docs

Ask 2 committers to review/merge the PR and tag them here.

@brendan-hofmann
@brjeter
@clockard
@lessarderic
@mcalcote
@ricklarsen - Documentation
@shaundmorris

How should this be tested?

  • builds successfully

Any background context you want to provide?

This is part of a larger revision of the Integrating documentation.

What are the relevant tickets?

For GH Issues:
Works towards: #4282 (partially)

Screenshots

int-docs.zip

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@ricklarsen
Copy link
Author

build now

@cxbot
Copy link

cxbot commented Feb 1, 2019

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Feb 1, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/6155/
✅ JOB SUCCESS

@ricklarsen
Copy link
Author

build now ... with updated commits

@cxbot
Copy link

cxbot commented Feb 1, 2019

Internal build has been scheduled, your results will be available at build completion.

@ricklarsen
Copy link
Author

build now

@cxbot
Copy link

cxbot commented Feb 4, 2019

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Feb 4, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/6174/
✅ JOB SUCCESS

Copy link
Contributor

@parret parret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hero'd successfully 👍

@ricklarsen ricklarsen merged commit 767cb94 into codice:master Feb 5, 2019
@ricklarsen ricklarsen deleted the DDF-04282 branch February 5, 2019 19:32
Kjames5269 pushed a commit to Kjames5269/ddf that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants