[2.19.x] Disable attributes that are not supported by selected sources #5827

mazarag2 · 2020-02-12T23:04:09Z

What does this PR do?

Disables attributes from the dropdown when a source with supportedAttributes is selected. Display a warning below the dropdown that the currently selected attribute is not available to be selected in the dropdown

Who is reviewing it?

Select relevant component teams:

@codice/ui

How should this be tested?

TBD

Any background context you want to provide?

TBD
These changes were done in catalog-ui-search which is now removed from master a forward port to ddf-ui will be necessary

What are the relevant tickets?

Fixes: #____

Screenshots

TBD

Checklist:

Documentation Updated
Update / Add Threat Dragon models
Update / Add Unit Tests
Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

5652 resolve conflict markers 5652 add missing settingsModel and check when other search forms are selected 5652 enable all attributes when no source is selected and clean up files 5652 fix comments

ui/packages/catalog-ui-search/src/main/webapp/component/filter-builder/filter-builder.view.js

ui/packages/catalog-ui-search/src/main/webapp/component/query-settings/query-settings.view.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/menu/menu.tsx

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

ui/packages/catalog-ui-search/src/main/webapp/component/query-advanced/query-advanced.view.js

ui/packages/catalog-ui-search/src/main/webapp/component/filter/filter.view.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

…inputs/enum-input/enum-input.js Co-Authored-By: David Morales <david.morales@connexta.com>

…-builder/filter-builder.view.js Co-Authored-By: David Morales <david.morales@connexta.com>

…stOfAttributes as a prop

ui/packages/catalog-ui-search/src/main/webapp/component/query-advanced/query-advanced.view.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/filter/filter.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/filter/filter.js

…advanced/query-advanced.view.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

…filter/filter.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

…filter/filter.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

ui/packages/catalog-ui-search/src/main/webapp/react-component/filter/filter.js

ui/packages/catalog-ui-search/src/main/webapp/component/filter/filter.view.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

ui/packages/catalog-ui-search/src/main/webapp/react-component/menu/menu.tsx

…filter/filter.js Co-Authored-By: David Morales <david.morales@connexta.com>

…havior in enum-input

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js

mojogitoverhere · 2020-02-26T22:07:53Z

build now

cxddfbot · 2020-02-26T22:11:19Z

Internal build has been started, your results will be available at build completion.

cxddfbot · 2020-02-26T22:21:06Z

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

mazarag2 · 2020-02-26T22:38:59Z

build now

cxddfbot · 2020-02-26T22:41:59Z

Internal build has been started, your results will be available at build completion.

mojogitoverhere · 2020-02-26T23:44:27Z

Working on the hero now

cxddfbot · 2020-02-27T01:51:18Z

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

mojogitoverhere · 2020-03-09T18:31:01Z

build now

cxddfbot · 2020-03-09T18:34:37Z

Internal build has been started, your results will be available at build completion.

cxddfbot · 2020-03-09T20:57:46Z

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

mojogitoverhere · 2020-03-12T20:53:13Z

🎉 Hero was successful! 🎉

Installed the standard profile
Verified queries and attribute dropdown still work as expected (no attributes filtered out)
Verified filtering functionality in downstream project

…selected sources (#130) Forward port of codice/ddf#5827 Disables attributes from the dropdown when a source with supportedAttributes is selected. Display a warning below the dropdown that the currently selected attribute is not available to be selected in the dropdown

mazarag2 added 2 commits February 12, 2020 15:08

5652 conflicts

e35b791

5652 resolve conflict markers 5652 add missing settingsModel and check when other search forms are selected 5652 enable all attributes when no source is selected and clean up files 5652 fix comments

5652 remove log

79f335b

mazarag2 requested a review from andrewkfiedler as a code owner February 12, 2020 23:04

bdeining changed the title ~~2.19.x disable attributes that are not supported by selected content stores~~ 2.19.x disable attributes that are not supported by selected sources Feb 12, 2020

Lambeaux approved these changes Feb 12, 2020

View reviewed changes

mojogitoverhere reviewed Feb 13, 2020

View reviewed changes

samuelechu requested changes Feb 13, 2020

View reviewed changes

mazarag2 and others added 5 commits February 14, 2020 09:07

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

3067f28

…inputs/enum-input/enum-input.js Co-Authored-By: David Morales <david.morales@connexta.com>

Update ui/packages/catalog-ui-search/src/main/webapp/component/filter…

5c34053

…-builder/filter-builder.view.js Co-Authored-By: David Morales <david.morales@connexta.com>

5652 pass src downn instead model

583c729

5652 refactor to bring supportedAttribute logic to filter and send li…

abbd0ed

…stOfAttributes as a prop

5652 simplify logic for disabling attribute

23b9aaa

kentmorrissey reviewed Feb 15, 2020

View reviewed changes

mazarag2 and others added 11 commits February 17, 2020 14:35

Update ui/packages/catalog-ui-search/src/main/webapp/component/query-…

adc960d

…advanced/query-advanced.view.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

2a9d5e8

…filter/filter.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

d21aae4

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

dcd794e

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

78a8bdf

…filter/filter.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

a66bd2b

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

4d2c372

…inputs/enum-input/enum-input.js Co-Authored-By: kentmorrissey <kentmorrissey0@gmail.com>

5652 formatting

09ea380

5652 remove fa class

f01550e

5652 refactor method and format

03c6351

5652 remove unncessary settingsMOdel and fix form

faa4dfd

mojogitoverhere reviewed Feb 19, 2020

View reviewed changes

mazarag2 and others added 3 commits February 20, 2020 09:33

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

c71f5bd

…filter/filter.js Co-Authored-By: David Morales <david.morales@connexta.com>

Update ui/packages/catalog-ui-search/src/main/webapp/react-component/…

3839955

…filter/filter.js Co-Authored-By: David Morales <david.morales@connexta.com>

5652 add Disabled prop to existing MenuItem and refactored disable be…

18acb1e

…havior in enum-input

mazarag2 added 5 commits February 21, 2020 17:43

5652 format

d35394f

5652 fix export in menu

a7035aa

5652 rename settingsModel to supportedAttributes

6b3702f

5652 use disabled prop for tooltip

f4d0289

5652 remove space

fa3e47e

brhumphe approved these changes Feb 26, 2020

View reviewed changes

bdeining changed the title ~~2.19.x disable attributes that are not supported by selected sources~~ [2.19.x] Disable attributes that are not supported by selected sources Feb 26, 2020

mojogitoverhere reviewed Feb 26, 2020

View reviewed changes

ui/packages/catalog-ui-search/src/main/webapp/react-component/inputs/enum-input/enum-input.js Outdated Show resolved Hide resolved

5652 refactor title string

22afceb

mojogitoverhere approved these changes Feb 26, 2020

View reviewed changes

brianfelix approved these changes Feb 26, 2020

View reviewed changes

5652 more format

d30b6ca

5652 check in filter if attributes are present

fb41775

mojogitoverhere merged commit 168254c into codice:2.19.x Mar 12, 2020

mazarag2 mentioned this pull request Mar 19, 2020

Identify Dropdown menu item that is an unsupported Attribute for the selected sources codice/ddf-ui#128

Closed

brhumphe mentioned this pull request Mar 23, 2020

Identify Dropdown menu item that is an unsupported Attribute for the selected sources codice/ddf-ui#130

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2.19.x] Disable attributes that are not supported by selected sources #5827

[2.19.x] Disable attributes that are not supported by selected sources #5827

mazarag2 commented Feb 12, 2020 •

edited

Loading

mojogitoverhere commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

mazarag2 commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

mojogitoverhere commented Feb 26, 2020

cxddfbot commented Feb 27, 2020

mojogitoverhere commented Mar 9, 2020

cxddfbot commented Mar 9, 2020

cxddfbot commented Mar 9, 2020

mojogitoverhere commented Mar 12, 2020

[2.19.x] Disable attributes that are not supported by selected sources #5827

[2.19.x] Disable attributes that are not supported by selected sources #5827

Conversation

mazarag2 commented Feb 12, 2020 • edited Loading

What does this PR do?

Who is reviewing it?

Select relevant component teams:

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Checklist:

Notes on Review Process

Review Comment Legend:

mojogitoverhere commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

mazarag2 commented Feb 26, 2020

cxddfbot commented Feb 26, 2020

mojogitoverhere commented Feb 26, 2020

cxddfbot commented Feb 27, 2020

mojogitoverhere commented Mar 9, 2020

cxddfbot commented Mar 9, 2020

cxddfbot commented Mar 9, 2020

mojogitoverhere commented Mar 12, 2020

🎉 Hero was successful! 🎉

mazarag2 commented Feb 12, 2020 •

edited

Loading