Skip to content

Fix buffer overflow issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix buffer overflow issue #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e0be1c
Fix buffer overflow issue by adjusting input buffer size and fgets usage
Jun 5, 2024
9c24086
Fix buffer overflow issue by limiting fgets input size
Jun 10, 2024
49487ef
Resolve merge conflicts
Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@

int main()
{
char name[64];
char name[128];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the buffer size from 64 to 128 characters is a good approach to handle longer inputs and prevent buffer overflow issues.


printf("Enter your name:\n");
fgets(name, sizeof(name) + 32, stdin);
fgets(name, sizeof(name), stdin);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting the fgets usage to sizeof(name) instead of sizeof(name) + 32 is crucial for preventing buffer overflows. Good fix!


// Remove the trailing newline character if present
name[strcspn(name, "\n")] = '\0';
Expand Down