Skip to content

add support for enc parameter for POST: /runs #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2019

Conversation

abhishek97
Copy link
Contributor

@abhishek97 abhishek97 commented Jan 16, 2019

Depends on #19

Issue: #16

@abhishek97 abhishek97 changed the title Run enc add support for enc parameter for POST: /runs Jan 16, 2019
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"target": "es2015",
"target": "es2016",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4c98006). Click here to learn what that means.
The diff coverage is 52.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   67.01%           
=========================================
  Files             ?       12           
  Lines             ?      194           
  Branches          ?       26           
=========================================
  Hits              ?      130           
  Misses            ?       47           
  Partials          ?       17
Impacted Files Coverage Δ
config.js 100% <ø> (ø)
src/db/models.ts 100% <ø> (ø)
src/validators/SubmissionValidators.ts 21.42% <16.66%> (ø)
src/utils/s3.ts 33.33% <33.33%> (ø)
src/utils/index.ts 57.14% <57.14%> (ø)
src/routes/api/run.ts 71.92% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c98006...93c97be. Read the comment docs.

@championswimmer championswimmer merged commit 13ba6c6 into coding-blocks:master Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants